RE: [EXTERNAL] Re: [PATCH v2 1/2] PCI: hv: Make the code arch neutral

From: Sunil Muthuswamy
Date: Wed Oct 13 2021 - 15:44:59 EST


On Tuesday, October 12, 2021 11:06 PM,
Boqun Feng <boqun.feng@xxxxxxxxx> wrote:

> As reported by Baihua (I can also reproduce), compile errors are hit
> when compiling with CONFIG_PCI_HYPERV=m:
>
> ERROR: modpost: missing MODULE_LICENSE() in drivers/pci/controller/pci-
> hyperv-irqchip.o
> ERROR: modpost: "hv_msi_prepare" [drivers/pci/controller/pci-hyperv.ko]
> undefined!
> ERROR: modpost: "hv_pci_irqchip_init" [drivers/pci/controller/pci-hyperv.ko]
> undefined!
> ERROR: modpost: "hv_pci_irqchip_free" [drivers/pci/controller/pci-hyperv.ko]
> undefined!
> ERROR: modpost: "hv_msi_get_int_vector" [drivers/pci/controller/pci-
> hyperv.ko] undefined!
> ERROR: modpost: "hv_set_msi_entry_from_desc" [drivers/pci/controller/pci-
> hyperv.ko] undefined!
>
> It means that we MODULE_LICENSE() should be added in
> pci-hyperv-irqchip.c, also these symbols should be exported.
>
Thanks for catching this. Will fix in v3.

- Sunil