Re: [mcgrof:modules-next 1/1] include/linux/kern_levels.h:5:18: warning: format '%llu' expects argument of type 'long long unsigned int', but argument 3 has type 'Elf32_Off' {aka 'unsigned int'}

From: Luis Chamberlain
Date: Wed Oct 13 2021 - 18:41:24 EST


On Wed, Oct 13, 2021 at 04:16:36PM -0600, Shuah Khan wrote:
> On 10/13/21 3:18 PM, Luis Chamberlain wrote:
> > On Wed, Oct 13, 2021 at 11:09:15AM -0600, Shuah Khan wrote:
> > > Hi Luis,
> > > We can introduce arch specific header print routine. Easy option is not
> > > printing any info., which we know isn't very useful.
> > >
> > > Let me know your thoughts.
> >
> > You found an issue without the debug prints, and so you'd know better if
> > the effort is worth the trouble, so I'll let you decide.
> >
>
> Right the issue with validate_section_offset() is separate from the debug.
> I will fix the pr_err warns first by tweaking the messages to not print
> the variables that cause problems.
>
> I will send a separate patch for validate_section_offset() which needs to
> be arch specific similar to elf_check_arch().
>
> Let me know if this plan sounds good.

Sounds good! Thanks for doing this work!

Luis