Re: [RESEND PATCH v1 7/9] spmi: pmic-arb: support updating interrupt type flags

[Fenglin Wu]

On 10/14/2021 3:37 AM, Stephen Boyd wrote:
> Quoting Fenglin Wu (2021-10-12 23:27:22)
> > copy IRQCHIP driver maintainers as requested in another patch.
> >
> > On 10/13/2021 1:42 AM, Stephen Boyd wrote:
> > > Quoting Fenglin Wu (2021-09-16 23:33:02)
> > > > From: Yimin Peng <yiminp@xxxxxxxxxxxxxx>
> > > >
> > > > Have the qpnpint_irq_set_type function clear unwanted high/low
> > > > trigger bits when updating the interrupt flags.
> > > Why?
> > There was a requirement to update the PMIC module interrupt type
> > dynamically
> > (such as from low level trigger to high level trigger), hence it's required
> > to clear the unnecessary trigger type when setting it.
> Can you clearly describe the problem in the commit text? Is this a bug
> fix?
sure, will do.
> > > > Signed-off-by: Yimin Peng <yiminp@xxxxxxxxxxxxxx>
> > > > Signed-off-by: Subbaraman Narayanamurthy <subbaram@xxxxxxxxxxxxxx>
> > > > Signed-off-by: Fenglin Wu <quic_fenglinw@xxxxxxxxxxx>
> > > > ---
> > > Does this need a Fixes tag?
> > Maybe no need to a Fixes tag because this is part of the initial code when
> > interrupt handling is added?
> Was it always broken? Or trigger types haven't been changing at runtime
> because most users are requesting irqs and forgetting about it? Are you
> using gpio-keys or something like that now? Adding a Fixes tag doesn't
> hurt.
You are right, it was reported by someone when using a PMIC GPIO and update
the interrupt at runtime, I am not sure if it's gpio-keys but that can be a
realistic case.
I will add a Fixes tag for it.