Re: [PATCH] nvme: Cleanup per-namespace chardev deletion

From: Christoph Hellwig
Date: Thu Oct 14 2021 - 02:04:36 EST


On Wed, Oct 13, 2021 at 03:04:19PM +0000, Adam Manzanares wrote:
> Decrease reference count of chardevice during char device deletion in order to
> fix a kmemleak. Add relese function for the device associated chardev and moved
> ida_simple_remove into the release function.
>
> Fixes: 2637bae (nvme: introduce generic per-namespace chardev)
> Reported-by: Yi Zhang <yi.zhang@xxxxxxxxxx>
> Suggested-by: Sagi Grimberg <sagi@xxxxxxxxxxx>
> Signed-off-by: Adam Manzanares <a.manzanares@xxxxxxxxxxx>

This looks good, but the subject seems wrong. This isn't a cleanup
but a fix. I can fix up the subject when applying it.