Re: [PATCH linux-next] ext4:namei: fix boolreturn.cocci warnings

[Jan Kara]

On Mon 23-08-21 22:55:43, CGEL wrote:
> From: Jing Yangyang <jing.yangyang@xxxxxxxxxx>
> 
> Return statements in functions returning bool should use true/false
> instead of 1/0.
> 
> ./fs/ext4/namei.c:1441:12-13:WARNING:return of 0/1 in function
> 'ext4_match' with return type bool
> 
> Reported-by: Zeal Robot <zealci@xxxxxxxxxx>
> Signed-off-by: Jing Yangyang <jing.yangyang@xxxxxxxxxx>

This seems to have fallen through the cracks. The fix looks good to me.
Feel free to add:

Reviewed-by: Jan Kara <jack@xxxxxxx>

								Honza

> ---
>  fs/ext4/namei.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/ext4/namei.c b/fs/ext4/namei.c
> index f3bbcd4..b5cb32d 100644
> --- a/fs/ext4/namei.c
> +++ b/fs/ext4/namei.c
> @@ -1438,7 +1438,7 @@ static bool ext4_match(struct inode *parent,
>  					fname->hinfo.minor_hash !=
>  						EXT4_DIRENT_MINOR_HASH(de)) {
>  
> -					return 0;
> +					return false;
>  				}
>  			}
>  			return !ext4_ci_compare(parent, &cf, de->name,
> -- 
> 1.8.3.1
> 
> 
-- 
Jan Kara <jack@xxxxxxxx>
SUSE Labs, CR