Re: [PATCH v2 4/4] selftests: net/fcnal: Test --{do,no}-bind-key-ifindex

From: David Ahern
Date: Thu Oct 14 2021 - 10:28:22 EST


On 10/13/21 12:50 AM, Leonard Crestez wrote:
> Test that applications binding listening sockets to VRFs without
> specifying TCP_MD5SIG_FLAG_IFINDEX will work as expected. This would
> be broken if __tcp_md5_do_lookup always made a strict comparison on
> l3index. See this email:
>
> https://lore.kernel.org/netdev/209548b5-27d2-2059-f2e9-2148f5a0291b@xxxxxxxxx/
>
> Applications using tcp_l3mdev_accept=1 and a single global socket (not
> bound to any interface) also should have a way to specify keys that are
> only for the default VRF, this is done by --do-bind-key-ifindex without
> otherwise binding to a device.
>
> Signed-off-by: Leonard Crestez <cdleonard@xxxxxxxxx>
> ---
> tools/testing/selftests/net/fcnal-test.sh | 60 +++++++++++++++++++++++
> 1 file changed, 60 insertions(+)
>

Reviewed-by: David Ahern <dsahern@xxxxxxxxxx>