Re: [PATCH v3] x86/PCI: Ignore E820 reservations for bridge windows on newer systems

From: Christoph Hellwig
Date: Thu Oct 14 2021 - 11:16:55 EST


On Thu, Oct 14, 2021 at 05:15:02PM +0200, Hans de Goede wrote:
> Hi,
>
> On 10/14/21 3:40 PM, Christoph Hellwig wrote:
> > On Thu, Oct 14, 2021 at 01:03:57PM +0200, Hans de Goede wrote:
> >> + * Some BIOS-es contain a bug where they add addresses which map to system
> >> + * RAM in the PCI bridge memory window returned by the ACPI _CRS method,
> >
> > Please avoid the overly long lines in your comments.
>
> ?
>
> These lines are easily within the new 100 char line-length-limit ?

That is an exceptional limit if exceeding 80 improves readability for
individual lines.

> And checkpatch also does not complain about this.

checkpatch has been completely broken for a while and should not be
relied on in any way.