Re: [PATCH v2 2/2] mailbox: mtk-cmdq: Fix local clock ID usage

From: Tzung-Bi Shih
Date: Thu Oct 14 2021 - 11:55:09 EST


On Thu, Oct 14, 2021 at 08:03:52PM +0800, Fei Shao wrote:
> In the probe function, the clock IDs were pointed to local variables
> which should only be used in the same code block, and any access to them
> after the probing stage becomes an use-after-free case.
>
> Since there are only limited variants of the gce clock names so far, we
> can just declare them as static constants to fix the issue.
>
> Fixes: 85dfdbfc13ea ("mailbox: cmdq: add multi-gce clocks support for
> mt8195")
> Signed-off-by: Fei Shao <fshao@xxxxxxxxxxxx>
Reviewed-by: Tzung-Bi Shih <tzungbi@xxxxxxxxxx>