Re: [PATCH] video: omapfb: Fix fall-through warning for Clang

From: Gustavo A. R. Silva
Date: Thu Oct 14 2021 - 14:30:19 EST


On Thu, Oct 14, 2021 at 08:26:52PM +0200, Sam Ravnborg wrote:
> Hi Gustavo,
> On Thu, Oct 14, 2021 at 11:53:20AM -0500, Gustavo A. R. Silva wrote:
> > Fix the following fallthrough warnings:
> >
> > drivers/video/fbdev/omap/omapfb_main.c:1558:2: warning: unannotated fall-through between switch labels [-Wimplicit-fallthrough]
> > case 0:
> > ^
> > drivers/video/fbdev/omap/omapfb_main.c:1558:2: note: insert 'break;' to avoid fall-through
> > case 0:
> > ^
> > break;
> > 1 warning generated.
> >
> > This helps with the ongoing efforts to globally enable
> > -Wimplicit-fallthrough for Clang.
> >
> > Link: https://github.com/KSPP/linux/issues/115
> > Link: https://lore.kernel.org/lkml/202110141005.hUjaYMEi-lkp@xxxxxxxxx/
> > Reported-by: kernel test robot <lkp@xxxxxxxxx>
> > Signed-off-by: Gustavo A. R. Silva <gustavoars@xxxxxxxxxx>
> applied to drm-misc-next. It will show up in -next in 1-2 weeks time.

Great. :)

Thanks, Sam.
--
Gustavo