Re: [RESEND PATCH v1 8/9] spmi: pmic-arb: make interrupt support optional

From: Fenglin Wu
Date: Thu Oct 14 2021 - 21:30:38 EST



On 10/15/2021 9:17 AM, Stephen Boyd wrote:
Quoting Fenglin Wu (2021-10-13 20:20:57)
On 10/14/2021 3:38 AM, Stephen Boyd wrote:
Quoting Fenglin Wu (2021-10-13 01:36:54)
On 10/13/2021 1:41 AM, Stephen Boyd wrote:
Quoting Fenglin Wu (2021-09-16 23:33:03)
From: David Collins <collinsd@xxxxxxxxxxxxxx>

Make the support of PMIC peripheral interrupts optional for
spmi-pmic-arb devices. This is useful in situations where
SPMI address mapping is required without the need for IRQ
support.

Signed-off-by: David Collins <collinsd@xxxxxxxxxxxxxx>
Signed-off-by: Fenglin Wu <quic_fenglinw@xxxxxxxxxxx>
---
drivers/spmi/spmi-pmic-arb.c | 45 +++++++++++++++++++++++++++-----------------
Is there a binding update? Can the binding be converted to YAML as well?
This change doesn't add/update any dtsi properties but just checking if an
existing property is present to decide if IRQ support is required, so no
binding change is needed.
The property is now optional in the binding. Please update the binding.
Right, thanks for pointing it out. I forgot that part.
I will update the binding. How about only update the interrupt properties as
optional in this series then I can come up with following patch to convert
the binding to YAML format?
Sure. The benefit of converting it to YAML is that we can use the
checker to quickly validate the binding vs. having to read the whole
thing to understand that it's correct. Converting an existing binding to
YAML shouldn't be that hard.
Thanks, will do that for sure after this series of the changes.