[PATCH v2] usb: typec: STUSB160X should select REGMAP_I2C

From: Randy Dunlap
Date: Thu Oct 14 2021 - 21:36:14 EST


REGMAP_I2C is not a user visible kconfig symbol so driver configs
should not "depend on" it. They should depend on I2C and then
select REGMAP_I2C.

If this worked, it was only because some other driver had set/enabled
REGMAP_I2C.

Fixes: da0cb6310094 ("usb: typec: add support for STUSB160x Type-C controller family")
Signed-off-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>
Cc: Heikki Krogerus <heikki.krogerus@xxxxxxxxxxxxxxx>
Cc: Amelie Delaunay <amelie.delaunay@xxxxxx>
Cc: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
Cc: linux-usb@xxxxxxxxxxxxxxx
Reviewed-by: Amelie Delaunay <amelie.delaunay@xxxxxxxxxxx>
Reviewed-by: Heikki Krogerus <heikki.krogerus@xxxxxxxxxxxxxxx>
---
v2: add Reviewed-by: tags
rebase and resend
add patch dependency (below)

This patch depends on this patch that is in usb-next:
[PATCH] usb: musb: select GENERIC_PHY instead of depending on it
lore.kernel.org/r/20211005235747.5588-1-rdunlap@xxxxxxxxxxxxx

drivers/usb/typec/Kconfig | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

--- linux-next-20211013.orig/drivers/usb/typec/Kconfig
+++ linux-next-20211013/drivers/usb/typec/Kconfig
@@ -65,9 +65,9 @@ config TYPEC_HD3SS3220

config TYPEC_STUSB160X
tristate "STMicroelectronics STUSB160x Type-C controller driver"
- depends on I2C
- depends on REGMAP_I2C
depends on USB_ROLE_SWITCH || !USB_ROLE_SWITCH
+ depends on I2C
+ select REGMAP_I2C
help
Say Y or M here if your system has STMicroelectronics STUSB160x
Type-C port controller.