Re: [PATCH v2 3/4] selftests: nettest: Add --{do,no}-bind-key-ifindex

[Leonard Crestez]

On 10/14/21 5:25 PM, David Ahern wrote:
> On 10/13/21 12:50 AM, Leonard Crestez wrote:
> > @@ -1856,10 +1870,14 @@ static void print_usage(char *prog)
> >   	"    -n num        number of times to send message\n"
> >   	"\n"
> >   	"    -M password   use MD5 sum protection\n"
> >   	"    -X password   MD5 password for client mode\n"
> >   	"    -m prefix/len prefix and length to use for MD5 key\n"
> > +	"    --no-bind-key-ifindex: Force TCP_MD5SIG_FLAG_IFINDEX off\n"
> > +	"    --do-bind-key-ifindex: Force TCP_MD5SIG_FLAG_IFINDEX on\n"
> > +	"        (default: only if -I is passed)\n"
>
> a nit:
> just --bind-key-ifindex and --no-bind-key-ifindex
>
> Reviewed-by: David Ahern <dsahern@xxxxxxxxxx>

That would be slightly confusing because it would be easy to assume that 
the default behavior is "--bind-key-ifindex".

Instead of using "--do-" as an intensifier I can use "--force-".

--
Regards,
Leonard