Re: [PATCH 0/2] KVM: x86: Revert to fix apic_hw_disabled underflow

From: Paolo Bonzini
Date: Fri Oct 15 2021 - 05:02:43 EST


On 13/10/21 02:35, Sean Christopherson wrote:
Revert (mostly) a patch from the vCPU RESET cleanup that open coded some
APIC shenanigans to avoid stuffing vcpu->arch.apic_base at vCPU creation,
and completely overlooked the side effects on apic_hw_disabled. I went
for a revert as I think the original behavior is the least awful solution,
just somewhat poorly documented.

The second patch adds WARNs to detect "overflow", where "overflow" means
KVM incorrectly increments apic_hw_disabled.

Sean Christopherson (2):
Revert "KVM: x86: Open code necessary bits of kvm_lapic_set_base() at
vCPU RESET"
KVM: x86: WARN if APIC HW/SW disable static keys are non-zero on
unload

arch/x86/kvm/lapic.c | 20 +++++++++++++-------
1 file changed, 13 insertions(+), 7 deletions(-)


Queued for 5.15, thanks.

Paolo