Re: [PATCH 5.14 05/30] interconnect: qcom: sdm660: Add missing a2noc qos clocks

From: Greg Kroah-Hartman
Date: Fri Oct 15 2021 - 07:32:01 EST


On Fri, Oct 15, 2021 at 02:24:52PM +0300, Georgi Djakov wrote:
> Hi Greg,
>
> On 14.10.21 17:54, Greg Kroah-Hartman wrote:
> > From: Shawn Guo <shawn.guo@xxxxxxxxxx>
> >
> > [ Upstream commit 13404ac8882f5225af07545215f4975a564c3740 ]
> >
> > It adds the missing a2noc clocks required for QoS registers programming
> > per downstream kernel[1]. Otherwise, qcom_icc_noc_set_qos_priority()
> > call on mas_ufs or mas_usb_hs node will simply result in a hardware hang
> > on SDM660 SoC.
> >
> > [1] https://source.codeaurora.org/quic/la/kernel/msm-4.4/tree/arch/arm/boot/dts/qcom/sdm660-bus.dtsi?h=LA.UM.8.2.r1-04800-sdm660.0#n43
> >
> > Signed-off-by: Shawn Guo <shawn.guo@xxxxxxxxxx>
> > Tested-by: Bjorn Andersson <bjorn.andersson@xxxxxxxxxx>
> > Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@xxxxxxxxxxxxxx>
> > Link: https://lore.kernel.org/r/20210824043435.23190-3-shawn.guo@xxxxxxxxxx
> > Signed-off-by: Georgi Djakov <djakov@xxxxxxxxxx>
> > Signed-off-by: Sasha Levin <sashal@xxxxxxxxxx>
>
> There is no benefit to backport this change, as devices that
> needed it, would not boot on v5.14 anyways. Please drop it.

Now dropped, thanks!

greg k-h