Re: [PATCH 1/5] arch_topology: Introduce thermal pressure update function

[Lukasz Luba]

Hi Thara,

Thank you having a look at these patches.
My apologies for the delay, I haven't felt well
recently.

On 10/11/21 10:15 PM, Thara Gopinath wrote:
> On 10/7/21 4:07 AM, Lukasz Luba wrote:

[snip]

> > +/**
> > + * topology_thermal_pressure_update() - Update thermal pressure for CPUs
> > + * @cpus    : The related CPUs which capacity has been reduced
>
> The related CPUs "for" which

thanks

> > + * @capped_freq    : The maximum allowed frequency that CPUs can run at

[snip]

> > +
> > +    capacity = capped_freq * max_capacity;
> > +    capacity /= per_cpu(freq_factor, cpu);
>
> use mult_frac as used in other implementations ?

Good point. Let me check that. In that arch_topology file we never
use such trick, but in this case it makes sense IMO.

Regards,
Lukasz