Re: [PATCH v6 26/48] mfd: ti_am335x_tscadc: Drop unused definitions from the header

From: Jonathan Cameron
Date: Fri Oct 15 2021 - 10:00:56 EST


On Fri, 15 Oct 2021 10:14:44 +0200
Miquel Raynal <miquel.raynal@xxxxxxxxxxx> wrote:

> The STEP ENABLE definitions are highly unclear and not used so drop them.
>
> Suggested-by: Jonathan Cameron <Jonathan.Cameron@xxxxxxxxxx>
> Signed-off-by: Miquel Raynal <miquel.raynal@xxxxxxxxxxx>
Reviewed-by: Jonathan Cameron <Jonathan.Cameron@xxxxxxxxxx>

Thanks for tidying that up.

> ---
> include/linux/mfd/ti_am335x_tscadc.h | 7 -------
> 1 file changed, 7 deletions(-)
>
> diff --git a/include/linux/mfd/ti_am335x_tscadc.h b/include/linux/mfd/ti_am335x_tscadc.h
> index a85643677bef..1cd8cd34f2b7 100644
> --- a/include/linux/mfd/ti_am335x_tscadc.h
> +++ b/include/linux/mfd/ti_am335x_tscadc.h
> @@ -39,13 +39,6 @@
> /* IRQ wakeup enable */
> #define IRQWKUP_ENB BIT(0)
>
> -/* Step Enable */
> -#define STEPENB_MASK (0x1FFFF << 0)
> -#define STEPENB(val) ((val) << 0)
> -#define ENB(val) (1 << (val))
> -#define STPENB_STEPENB STEPENB(0x1FFFF)
> -#define STPENB_STEPENB_TC STEPENB(0x1FFF)
> -
> /* IRQ enable */
> #define IRQENB_HW_PEN BIT(0)
> #define IRQENB_EOS BIT(1)