Re: [PATCH v5 2/2] gpio: gpio-cascade: add generic GPIO cascade

[Andy Shevchenko]

On Fri, Oct 15, 2021 at 3:56 PM Mauri Sandberg <maukka@xxxxxxxxxxxx> wrote:
> On 21.6.2021 20.43, Andy Shevchenko wrote:
>
> >> +       gc->of_node = np;
> >
> > This should be guarded by CONFIG_OF_GPIO.

The above is actually done by the GPIO library nowadays.

> In the Kconfig I have a dependency to OF_GPIO. Is the guarding still
> necessary? Or should the guard be added and dependency removed? Or have
> them both?

For this kind ("generic") driver the OF_GPIO dependency is simply
wrong. You shouldn't have it.

-- 
With Best Regards,
Andy Shevchenko