Re: [PATCH v3 1/2] [RFT] clk: samsung: add support for CPU clocks

From: Sylwester Nawrocki
Date: Fri Oct 15 2021 - 10:36:58 EST


On 14.10.2021 23:40, Stephen Boyd wrote:
Quoting Will McVicker (2021-10-14 12:35:57)
On Wed, Oct 13, 2021 at 6:49 PM Stephen Boyd <sboyd@xxxxxxxxxx> wrote:
Quoting Will McVicker (2021-10-13 15:10:19)
diff --git a/drivers/clk/samsung/clk-cpu.c b/drivers/clk/samsung/clk-cpu.c


+ if (parent_clk)
+ parent_clk_hw = __clk_get_hw(parent_clk);
+ alt_parent_clk = __clk_lookup(list->alt_parent_name);

Can the DT binding be updated?

Are you referring to removing alt_parent and just adding it as another
parent clock?


I was wondering if this is an external clk that feeds into here or if it
is all internal to the clk controller. It sounds like it's all internal
to the clk controller? In which case a binding update isn't needed.

Yes, I double checked and the cpu parent clocks are always internal to
the clock provider. There is one exception where physically a parent clock
comes from other CMU (exynos5250), but in that case all CMUs are modeled
as a single clk provider anyway. Thus we don't need a binding update.