Re: [PATCH v10 07/11] x86/tdx: Add HLT support for TDX guest

From: Sean Christopherson
Date: Fri Oct 15 2021 - 11:03:45 EST


On Thu, Oct 14, 2021, Sathyanarayanan Kuppuswamy wrote:
>
> On 10/14/21 2:30 AM, Thomas Gleixner wrote:
> > On Fri, Oct 08 2021 at 22:37, Kuppuswamy Sathyanarayanan wrote:
> > > +/* HLT TDVMCALL sub-function ID */
> > > +#define EXIT_REASON_HLT 12
> > arch/x86/include/uapi/asm/vmx.h:#define EXIT_REASON_HLT 12
> >
> > Is there a _good_ reason why this can't be reused?

So, no. :-D

> As per current use case we can re-use it. Out of all TDX hypercall sub
> function IDs, only Instruction.PCONFIG (65) exit reason id is missing in
> vmx.h. But currently we are not handling it. So we can ignore it for now.

If the kernel proper needs EXIT_REASON_PCONFIG before KVM, just send a patch...