Re: [PATCH v2] staging: vt6655: Rename byPreambleType field

From: Greg KH
Date: Fri Oct 15 2021 - 11:11:04 EST


On Fri, Oct 15, 2021 at 03:47:46PM +0100, Karolina Drobnik wrote:
> Hi Greg,
>
> On Fri, 2021-10-15 at 13:20 +0200, Greg KH wrote:
> > Do not do multiple different things in the same commit and especially
> > when you do not describe them in the changelog text.
>
> I wasn't aware that changing this preamble-related variable would be
> counted as a different thing. It makes sense, my bad.
>
> Would you like me to amend the message to say that I also changed
> `bb_get_frame_time` parameter or just drop this change completely?

I think I already answered this :)