RE: [PATCH] Input: adxl34x - fix sparse warning

From: Hennerich, Michael
Date: Fri Oct 15 2021 - 11:20:27 EST


> -----Original Message-----
> From: Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx>
> Sent: Mittwoch, 13. Oktober 2021 04:47
> To: Hennerich, Michael <Michael.Hennerich@xxxxxxxxxx>
> Cc: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>; linux-
> input@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx
> Subject: [PATCH] Input: adxl34x - fix sparse warning
>
> This fixes the following warning from sparse:
>
> CC [M] drivers/input/misc/adxl34x.o
> CHECK drivers/input/misc/adxl34x.c
> drivers/input/misc/adxl34x.c:245:29: warning: cast to restricted __le16
> drivers/input/misc/adxl34x.c:248:29: warning: cast to restricted __le16
> drivers/input/misc/adxl34x.c:251:29: warning: cast to restricted __le16
>
> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx>

Acked-by: Michael Hennerich <michael.hennerich@xxxxxxxxxx>

> ---
> drivers/input/misc/adxl34x.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/input/misc/adxl34x.c b/drivers/input/misc/adxl34x.c index
> 34beac80e6f0..a4af314392a9 100644
> --- a/drivers/input/misc/adxl34x.c
> +++ b/drivers/input/misc/adxl34x.c
> @@ -237,7 +237,7 @@ static const struct adxl34x_platform_data
> adxl34x_default_init = {
>
> static void adxl34x_get_triple(struct adxl34x *ac, struct axis_triple *axis) {
> - short buf[3];
> + __le16 buf[3];
>
> ac->bops->read_block(ac->dev, DATAX0, DATAZ1 - DATAX0 + 1, buf);
>
> --
> 2.33.0.882.g93a45727a2-goog
>
>
> --
> Dmitry