Re: [PATCH 7/8] watchdog: max77714: add driver for the watchdog in the MAX77714 PMIC

[Luca Ceresoli]

Hi,

On 11/10/21 19:17, Guenter Roeck wrote:
> On 10/11/21 8:56 AM, Luca Ceresoli wrote:
[...]
>> diff --git a/drivers/watchdog/max77714_wdt.c
>> b/drivers/watchdog/max77714_wdt.c
>> new file mode 100644
>> index 000000000000..2d468db849f9
>> --- /dev/null
>> +++ b/drivers/watchdog/max77714_wdt.c
>> @@ -0,0 +1,171 @@
>> +// SPDX-License-Identifier: GPL-2.0-only
>> +/*
>> + * Maxim MAX77714 Watchdog Driver
>> + *
>> + * Copyright (C) 2021 Luca Ceresoli
>> + * Author: Luca Ceresoli <luca@xxxxxxxxxxxxxxxx>
>> + */
>> +
>> +#include <linux/err.h>
>> +#include <linux/kernel.h>
>> +#include <linux/mfd/max77714.h>
>> +#include <linux/module.h>
>> +#include <linux/platform_device.h>
>> +#include <linux/regmap.h>
>> +#include <linux/watchdog.h>
>> +
>> +struct max77714_wdt {
>> +    struct device        *dev;
>> +    struct regmap        *rmap;
>> +    struct watchdog_device    wd_dev;
>> +};
>> +
>> +/* Timeout in seconds, indexed by TWD bits of CNFG_GLBL2 register */
>> +unsigned int max77714_margin_value[] = { 2, 16, 64, 128 };
> 
> static

Absolutely. And const too. Will fix.

-- 
Luca