Re: [PATCH 0/7] staging: r8188eu: odm cleanups

[Michael Straube]

On 10/15/21 20:07, Phillip Potter wrote:
> On Fri, Oct 15, 2021 at 06:35:00PM +0200, Michael Straube wrote:
> > This series removes:
> > - empty / unused functions from odm.c
> > - two never set / unused fields from odm_dm_struct
> > - the function ODM_CmnInfoPtrArrayHook()
> >
> > Tested on x86_64 with Inter-Tech DMG-02.
> >
> > Michael Straube (7):
> >    staging: r8188eu: remove empty functions from odm.c
> >    staging: r8188eu: remove ODM_SingleDualAntennaDefaultSetting()
> >    staging: r8188eu: remove GetPSDData()
> >    staging: r8188eu: remove ODM_AntselStatistics_88C()
> >    staging: r8188eu: pBandType is never set
> >    staging: r8188eu: pMacPhyMode is not used
> >    staging: r8188eu: remove ODM_CmnInfoPtrArrayHook()
> >
> >   drivers/staging/r8188eu/hal/HalPhyRf_8188e.c  |   2 +-
> >   drivers/staging/r8188eu/hal/odm.c             | 144 ------------------
> >   drivers/staging/r8188eu/hal/odm_HWConfig.c    |   7 +-
> >   drivers/staging/r8188eu/hal/odm_interface.c   |   5 -
> >   drivers/staging/r8188eu/hal/rtl8188e_dm.c     |   2 +-
> >   .../staging/r8188eu/hal/rtl8188e_hal_init.c   |   5 +-
> >   drivers/staging/r8188eu/include/odm.h         |  38 -----
> >   .../staging/r8188eu/include/odm_interface.h   |   2 -
> >   drivers/staging/r8188eu/include/odm_precomp.h |   2 -
> >   9 files changed, 6 insertions(+), 201 deletions(-)
> >
> > --
> > 2.33.0
>
> Dear Michael,
>
> Looks good to me. Built and tested on my USB-N10 Nano, works well. Many
> thanks.
>
> For whole series:
> Acked-by: Phillip Potter <phil@xxxxxxxxxxxxxxxx>
>
> Regards,
> Phil

Thank you for testing and your ack Phillip.

Regards,
Michael