Re: [PATCH] Fix user namespace leak
From: Trond Myklebust
Date: Fri Oct 15 2021 - 17:19:53 EST
On Fri, 2021-10-15 at 09:43 -0500, Eric W. Biederman wrote:
> Alexey Gladkov <legion@xxxxxxxxxx> writes:
>
> > Fixes: 61ca2c4afd9d ("NFS: Only reference user namespace from
> > nfs4idmap struct instead of cred")
> > Signed-off-by: Alexey Gladkov <legion@xxxxxxxxxx>
>
> Reviewed-by: "Eric W. Biederman" <ebiederm@xxxxxxxxxxxx>
>
> nfs folks do you want to pick this up?
It is in my testing branch,
>
> > ---
> > fs/nfs/nfs4idmap.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/fs/nfs/nfs4idmap.c b/fs/nfs/nfs4idmap.c
> > index 8d8aba305ecc..f331866dd418 100644
> > --- a/fs/nfs/nfs4idmap.c
> > +++ b/fs/nfs/nfs4idmap.c
> > @@ -487,7 +487,7 @@ nfs_idmap_new(struct nfs_client *clp)
> > err_destroy_pipe:
> > rpc_destroy_pipe_data(idmap->idmap_pipe);
> > err:
> > - get_user_ns(idmap->user_ns);
> > + put_user_ns(idmap->user_ns);
> > kfree(idmap);
> > return error;
> > }
--
Trond Myklebust
Linux NFS client maintainer, Hammerspace
trond.myklebust@xxxxxxxxxxxxxxx