Re: [PATCH] pinctrl: amd: Fix wakeups when IRQ is shared with SCI

From: Joerie de Gram
Date: Fri Oct 15 2021 - 19:54:17 EST


On Fri, Oct 15, 2021 at 09:43:32AM -0500, Mario Limonciello wrote:
> + if (irq < 0 && !(regval & BIT(WAKE_STS_OFF)))
> + return true;

Shouldn't be negated. WAKE_STS_OFF is set on wakeup.

With that change:

Reported-by: Joerie de Gram <j.de.gram@xxxxxxxxx>
Tested-by: Joerie de Gram <j.de.gram@xxxxxxxxx>