Re: [PATCH 2/3] serial: liteuart: fix use-after-free and memleak on unbind

[Johan Hovold]

On Tue, Nov 16, 2021 at 06:15:05AM +0900, Stafford Horne wrote:
> On Mon, Nov 15, 2021 at 02:37:44PM +0100, Johan Hovold wrote:
> > Deregister the port when unbinding the driver to prevent it from being
> > used after releasing the driver data and leaking memory allocated by
> > serial core.
> 
> This looks good to me.  Just curious did you test this on a Litex
> SoC/FPGA?

No, this series has only been compile tested.

> > Fixes: 1da81e5562fa ("drivers/tty/serial: add LiteUART driver")
> > Cc: stable@xxxxxxxxxxxxxxx      # 5.11
> > Cc: Filip Kokosinski <fkokosinski@xxxxxxxxxxxx>
> > Cc: Mateusz Holenko <mholenko@xxxxxxxxxxxx>
> > Cc: Stafford Horne <shorne@xxxxxxxxx>
> > Signed-off-by: Johan Hovold <johan@xxxxxxxxxx>
> 
> Reviewed-by: Stafford Horne <shorne@xxxxxxxxx>

Thanks for reviewing.

Johan