Re: [PATCH v3 0/9] backlight: qcom-wled: fix and solidify handling of enabled-strings

From: Lee Jones
Date: Tue Nov 16 2021 - 10:43:09 EST


On Tue, 16 Nov 2021, Daniel Thompson wrote:

> Hi Lee
>
> On Mon, Nov 15, 2021 at 09:34:50PM +0100, Marijn Suijten wrote:
> > This patchset fixes WLED's handling of enabled-strings: besides some
> > cleanup it is now actually possible to specify a non-contiguous array of
> > enabled strings (not necessarily starting at zero) and the values from
> > DT are now validated to prevent possible unexpected out-of-bounds
> > register and array element accesses.
> > Off-by-one mistakes in the maximum number of strings, also causing
> > out-of-bounds access, have been addressed as well.
>
> They have arrived piecemeal (during v1, v2 and v3) but all patches on
> the set should now have my R-b: attached to them.

I can see that. Nothing for you to worry about.

I'll apply these when I conduct my next sweep, thanks.

--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog