Re: [PATCH] watchdog: meson_gxbb_wdt: remove stop_on_reboot

[Guenter Roeck]

On Wed, Nov 10, 2021 at 10:25:18AM +0800, Artem Lapkin wrote:
> Remove watchdog_stop_on_reboot()
> 
> The Meson platform still has some hardware drivers problems for some
> configurations which can freeze devices on shutdown/reboot.
> 
> Remove watchdog_stop_on_reboot() to catch this situation and ensure that
> the reboot happens anyway. Users who still want to stop the watchdog on
> reboot can still do so using the watchdog.stop_on_reboot=1 module
> parameter.
> 
> https://lore.kernel.org/linux-watchdog/20210729072308.1908904-1-art@xxxxxxxxxx/T/#t
> 
> Signed-off-by: Artem Lapkin <art@xxxxxxxxxx>

Reviewed-by: Guenter Roeck <linux@xxxxxxxxxxxx>

> ---
>  drivers/watchdog/meson_gxbb_wdt.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/watchdog/meson_gxbb_wdt.c b/drivers/watchdog/meson_gxbb_wdt.c
> index 5a9ca10fbcfa..3f86530c33b0 100644
> --- a/drivers/watchdog/meson_gxbb_wdt.c
> +++ b/drivers/watchdog/meson_gxbb_wdt.c
> @@ -186,7 +186,6 @@ static int meson_gxbb_wdt_probe(struct platform_device *pdev)
>  
>  	meson_gxbb_wdt_set_timeout(&data->wdt_dev, data->wdt_dev.timeout);
>  
> -	watchdog_stop_on_reboot(&data->wdt_dev);
>  	return devm_watchdog_register_device(dev, &data->wdt_dev);
>  }
>  
> -- 
> 2.25.1
>