Re: [PATCH net-next] neigh: introduce __neigh_confirm() for __ipv{4, 6}_confirm_neigh

From: David Ahern
Date: Wed Nov 17 2021 - 14:35:59 EST


On 11/17/21 5:02 AM, Yajun Deng wrote:
> - unsigned long now = jiffies;
> -
> - /* avoid dirtying neighbour */
> - if (READ_ONCE(n->confirmed) != now)
> - WRITE_ONCE(n->confirmed, now);

Just move this part to neigh_confirm and leave the rest as it is. That
READ_ONCE, WRITE_ONCE pair exists in other places that could use the
neigh_confirm style helper.