Re: [PATCH] of: property: fw_devlink: Fixup behaviour when 'node_not_dev' is set

From: Rob Herring
Date: Thu Nov 18 2021 - 09:14:26 EST


On Thu, 02 Sep 2021 11:02:21 +0200, Ulf Hansson wrote:
> In the struct supplier_bindings the member 'node_not_dev' is described as
> "The consumer node containing the property is never a device.", but that is
> inconsistent with the behaviour of the code in of_link_property(), as it
> calls of_get_compat_node() that starts parsing for a compatible property
> from the node it gets passed to it. The proper behaviour is to start at the
> node's parent, so let's do that.
>
> While at it, let's take the opportunity to update the description of the
> 'node_not_dev' flag, as to clarify its purpose.
>
> Signed-off-by: Ulf Hansson <ulf.hansson@xxxxxxxxxx>
> ---
> drivers/of/property.c | 17 +++++++++++++++--
> 1 file changed, 15 insertions(+), 2 deletions(-)
>

Applied, thanks!