Re: [PATCH] x86/paravirt: Fix build PARAVIRT_XXL=y without XEN_PV

From: Kirill A. Shutemov
Date: Fri Nov 19 2021 - 05:21:27 EST


On Thu, Nov 18, 2021 at 07:23:51AM +0100, Juergen Gross wrote:
> On 17.11.21 19:14, Kirill A. Shutemov wrote:
> > TDX is going to use CONFIG_PARAVIRT_XXL, but kernel fails to compile if
> > XEN_PV is not enabled:
> >
> > ld.lld: error: undefined symbol: xen_iret
> >
> > It happens because INTERRUPT_RETURN defined to use xen_iret if
> > CONFIG_PARAVIRT_XXL enabled regardless of CONFIG_XEN_PV.
> >
> > The issue is not visible in the current kernel because CONFIG_XEN_PV is
> > the only user of CONFIG_PARAVIRT_XXL and there's no way to enable them
> > separately.
> >
> > Rework code to define INTERRUPT_RETURN based on CONFIG_XEN_PV, not
> > CONFIG_PARAVIRT_XXL.
> >
> > Signed-off-by: Kirill A. Shutemov <kirill.shutemov@xxxxxxxxxxxxxxx>
> > Cc: Juergen Gross <jgross@xxxxxxxx>
> > Cc: Deep Shah <sdeep@xxxxxxxxxx>
> > Cc: "VMware, Inc." <pv-drivers@xxxxxxxxxx>
>
> I agree with the patch, so:
>
> Reviewed-by: Juergen Gross <jgross@xxxxxxxx>
>
> Nevertheless I believe that TDX should not switch to use PARAVIRT_XXL.

Do I need to resend without TDX mention?

--
Kirill A. Shutemov