Re: [pinctrl-intel:review-andy 18/19] drivers/pinctrl/pinctrl-zynqmp.c:825:13: warning: variable 'pin' is uninitialized when used here

From: Andy Shevchenko
Date: Fri Nov 19 2021 - 12:46:07 EST


On Fri, Nov 19, 2021 at 10:20:35AM -0700, Nathan Chancellor wrote:
> On Fri, Nov 19, 2021 at 10:33:36AM +0200, Andy Shevchenko wrote:
> > On Fri, Nov 19, 2021 at 04:08:32PM +0800, kernel test robot wrote:

...

> > > All warnings (new ones prefixed by >>):
> > >
> > > >> drivers/pinctrl/pinctrl-zynqmp.c:825:13: warning: variable 'pin' is uninitialized when used here [-Wuninitialized]
> > > if (IS_ERR(pin->name))
> > > ^~~
> > > drivers/pinctrl/pinctrl-zynqmp.c:811:37: note: initialize the variable 'pin' to silence this warning
> > > struct pinctrl_pin_desc *pins, *pin;
> > > ^
> > > = NULL
> > > 1 warning generated.
> >
> > Utterly inappropriate suggestion by the compiler (it found an actual error,
> > though).
> >
> > Can be Clang fixed, really?
>
> I reported this upstream: https://bugs.llvm.org/show_bug.cgi?id=52559

Thanks!

--
With Best Regards,
Andy Shevchenko