RE: [PATCH 1/4] dt-bindings: net: fec: simplify yaml

From: Joakim Zhang
Date: Sun Nov 21 2021 - 21:07:27 EST



Hi Peng,

Thanks a lot for helping upstream this patch set.

For this change, have you run 'make dtbs_check'? I remember that split them to pass dtbs_check when convert it into yaml.

Best Regards,
Joakim Zhang
> -----Original Message-----
> From: Peng Fan (OSS) <peng.fan@xxxxxxxxxxx>
> Sent: 2021年11月20日 19:58
> To: robh+dt@xxxxxxxxxx; Aisheng Dong <aisheng.dong@xxxxxxx>; Joakim
> Zhang <qiangqing.zhang@xxxxxxx>; davem@xxxxxxxxxxxxx;
> kuba@xxxxxxxxxx; shawnguo@xxxxxxxxxx; s.hauer@xxxxxxxxxxxxxx
> Cc: kernel@xxxxxxxxxxxxxx; festevam@xxxxxxxxx; dl-linux-imx
> <linux-imx@xxxxxxx>; netdev@xxxxxxxxxxxxxxx;
> devicetree@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx;
> linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; Peng Fan <peng.fan@xxxxxxx>
> Subject: [PATCH 1/4] dt-bindings: net: fec: simplify yaml
>
> From: Peng Fan <peng.fan@xxxxxxx>
>
> i.MX7D, i.MX8MQ and i.MX8QM are compatible with i.MX6SX, so no need to
> split them into three items.
>
> Signed-off-by: Peng Fan <peng.fan@xxxxxxx>
> ---
> Documentation/devicetree/bindings/net/fsl,fec.yaml | 8 ++------
> 1 file changed, 2 insertions(+), 6 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/net/fsl,fec.yaml
> b/Documentation/devicetree/bindings/net/fsl,fec.yaml
> index eca41443fcce..dbf63a9c2a46 100644
> --- a/Documentation/devicetree/bindings/net/fsl,fec.yaml
> +++ b/Documentation/devicetree/bindings/net/fsl,fec.yaml
> @@ -39,9 +39,8 @@ properties:
> - items:
> - enum:
> - fsl,imx7d-fec
> - - const: fsl,imx6sx-fec
> - - items:
> - - const: fsl,imx8mq-fec
> + - fsl,imx8mq-fec
> + - fsl,imx8qm-fec
> - const: fsl,imx6sx-fec
> - items:
> - enum:
> @@ -50,9 +49,6 @@ properties:
> - fsl,imx8mp-fec
> - const: fsl,imx8mq-fec
> - const: fsl,imx6sx-fec
> - - items:
> - - const: fsl,imx8qm-fec
> - - const: fsl,imx6sx-fec
> - items:
> - enum:
> - fsl,imx8qxp-fec
> --
> 2.25.1