Re: [PATCH v2 16/20] linux/compiler.h, linux/array_size.h: Move __must_be_array() into <linux/array_size.h>

[Jani Nikula]

On Sun, 21 Nov 2021, Arnd Bergmann <arnd@xxxxxxxx> wrote:
> On Sat, Nov 20, 2021 at 2:01 PM Alejandro Colomar
> <alx.manpages@xxxxxxxxx> wrote:
>>
>> Signed-off-by: Alejandro Colomar <alx.manpages@xxxxxxxxx>
>
> Each patch should describe why you move this, it's not clear what the
> benefit is here.
>
>> diff --git a/drivers/gpu/drm/i915/i915_utils.h b/drivers/gpu/drm/i915/i915_utils.h
>> index 7a5925072466..f6fc1c72dfa7 100644
>> --- a/drivers/gpu/drm/i915/i915_utils.h
>> +++ b/drivers/gpu/drm/i915/i915_utils.h
>> @@ -25,6 +25,8 @@
>>  #ifndef __I915_UTILS_H
>>  #define __I915_UTILS_H
>>
>> +
>> +#include <linux/array_size.h>
>
> Avoid adding the extra whitespace here.

And throughout the series, really. In particular, please avoid adding
the double blank lines both in old and new files.

BR,
Jani.

>
>      Arnd

-- 
Jani Nikula, Intel Open Source Graphics Center