Re: [PATCH 2/2] Staging: rtl8712: rtl871x_security: fixed a camel case variable name coding style issue

From: Dan Carpenter
Date: Mon Nov 22 2021 - 05:40:17 EST


On Sat, Nov 20, 2021 at 11:11:51AM +0000, Zoeb Mithaiwala wrote:
> Changed additional 'n' from variable name. Corrected comment indentation.
>

This is not how you're supposed to send a v2 patch.
https://kernelnewbies.org/FirstKernelPatch See the section on "Revising
your patches".

> @@ -200,11 +200,11 @@ void seccalctkipmic(
> u8 *header,
> u8 *data,
> u32 data_len,
> - u8 *miccode,
> + u8 *Miccode,
> u8 priority);
>

Take a look at the naming in the .c file where the function is
implemented and use the same name in the .h file where it's declared.

regards,
dan carpenter