Re: [PATCH v2 2/2] i2c:imx: Add an extra read at the end of an I2C slave read

From: Wolfram Sang
Date: Tue Nov 23 2021 - 05:28:48 EST


On Fri, Nov 12, 2021 at 07:39:56AM -0600, minyard@xxxxxxx wrote:
> From: Corey Minyard <minyard@xxxxxxx>
>
> The I2C slave interface expects that the driver will read ahead one
> byte. The IMX driver/device doesn't do this, but simulate it so that
> read operations get their index set correctly.

From what I understand, the patch is correct but the description may be
wrong?

AFAIU the patch adds the slave event I2C_SLAVE_READ_PROCESSED to the
case when the last byte was transferred. We as the client got a NAK from
the controller. However, the byte WAS processed, so the event is ok and
not a dummy?

Attachment: signature.asc
Description: PGP signature