Re: [PATCH 1/2] media: i2c: imx274: simplify probe function by adding local variable dev

From: Sakari Ailus
Date: Tue Nov 23 2021 - 06:26:24 EST


Hi Eugen,

On Tue, Nov 23, 2021 at 01:15:20PM +0200, Eugen Hristev wrote:
> Simplify probe function by adding a local variable dev instead of using
> &client->dev all the time.
>
> Signed-off-by: Eugen Hristev <eugen.hristev@xxxxxxxxxxxxx>

It's not really wrong to do this, but is it useful?

You can't even unwrap a single line, the lines are just made a little bit
shorter.

--
Kind regards,

Sakari Ailus