Re: [PATCH v3 07/13] clk: imx: Add initial support for i.MXRT clock driver

[Giulio Benetti]

Hi Jesse, Fabio,

On 28/11/21 21:52, Jesse Taube wrote:
> On 11/28/21 15:50, Fabio Estevam wrote:
> > On Thu, Nov 25, 2021 at 6:14 PM Jesse Taube <mr.bossman075@xxxxxxxxx> wrote:
> > > From: Jesse Taube <mr.bossman075@xxxxxxxxx>
> > >
> > > This patch adds initial clock driver support for the i.MXRT series.

Also the commit log must be modified according(Summary+body).

Thank you
--
Giulio Benetti
Benetti Engineering sas

> > > Signed-off-by: Jesse Taube <Mr.Bossman075@xxxxxxxxx>
> > > Suggested-by: Giulio Benetti <giulio.benetti@xxxxxxxxxxxxxxxxxxxxxx>
> > > ---
> > > V1->V2:
> > > * Kconfig: Add new line
> > > * clk-imxrt.c: Remove unused const
> > > * clk-imxrt.c: Remove set parents
> > > * clk-imxrt.c: Use fsl,imxrt-anatop for anatop base address
> > > V2->V3:
> > > * Remove unused ANATOP_BASE_ADDR
> > > * Move to hw API
> > > * Add GPT's own clock
> > > * Add SEMC clocks to set muxing to CRITICAL
> > > ---
> > >    drivers/clk/imx/Kconfig     |   4 +
> > >    drivers/clk/imx/Makefile    |   1 +
> > >    drivers/clk/imx/clk-imxrt.c | 156 ++++++++++++++++++++++++++++++++++++
> >
> > Wouldn't it be better to name it clk-imxrt1050.c instead?
> we can have multiple imxrt versions in there like the other IMX clk
> drivers, is this okay?
> >