Re: [PATCH 22/23] arm64: dts: fsd: Add ADC device tree node

From: Krzysztof Kozlowski
Date: Thu Jan 13 2022 - 08:33:36 EST


On 13/01/2022 13:11, Alim Akhtar wrote:
> This patch adds ADC device tree node and enables the same
> on fsd platform.
>
> Cc: linux-fsd@xxxxxxxxx
> Signed-off-by: Tamseel Shams <m.shams@xxxxxxxxxxx>
> Signed-off-by: Alim Akhtar <alim.akhtar@xxxxxxxxxxx>
> ---
> arch/arm64/boot/dts/tesla/fsd.dts | 4 ++++
> arch/arm64/boot/dts/tesla/fsd.dtsi | 11 +++++++++++
> 2 files changed, 15 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/tesla/fsd.dts b/arch/arm64/boot/dts/tesla/fsd.dts
> index 7f3bb6212e50..dd6c75fc3221 100644
> --- a/arch/arm64/boot/dts/tesla/fsd.dts
> +++ b/arch/arm64/boot/dts/tesla/fsd.dts
> @@ -150,3 +150,7 @@
> &spi_2 {
> status = "okay";
> };
> +
> +&adc {
> + status = "okay";
> +};
> diff --git a/arch/arm64/boot/dts/tesla/fsd.dtsi b/arch/arm64/boot/dts/tesla/fsd.dtsi
> index 7e687c6f74f6..058a9d381aed 100644
> --- a/arch/arm64/boot/dts/tesla/fsd.dtsi
> +++ b/arch/arm64/boot/dts/tesla/fsd.dtsi
> @@ -788,6 +788,17 @@
> num-cs = <1>;
> status = "disabled";
> };
> +
> + adc: adc@141A0000 {

lowercase hex numbers please.

> + compatible = "samsung,exynos-adc-v3";
> + reg = <0x0 0x141A0000 0x0 0x100>;
> + interrupts = <GIC_SPI 173 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&clock_peric PERIC_PCLK_ADCIF>;
> + clock-names = "adc";
> + #io-channel-cells = <1>;
> + io-channel-ranges;
> + status = "disabled";

This does not pass dtschema. NAK.

> + };
> };
> };
>
>


Best regards,
Krzysztof