Re: [PATCH] iio: adc: ad7124: fix mask used for setting AIN_BUFP & AIN_BUFM bits

[Cosmin Tanislav]

On 1/15/22 20:56, Jonathan Cameron wrote:
> On Wed, 12 Jan 2022 22:00:36 +0200
> Cosmin Tanislav <demonsingur@xxxxxxxxx> wrote:
>
> > According to page 90 of the datasheet [1], AIN_BUFP is bit 6 and
> > AIN_BUFM is bit 5 of the CONFIG_0 -> CONFIG_7 registers.
> >
> > Fix the mask used for setting these bits.
> >
> > [1]: https://www.analog.com/media/en/technical-documentation/data-sheets/ad7124-8.pdf
> >
> > Fixes: 0eaecea6e487 ("iio: adc: ad7124: Add buffered input support")
> > Signed-off-by: Cosmin Tanislav <cosmin.tanislav@xxxxxxxxxx>
> Curious that didn't cause problems anyone noticed before. Ah well.

I only noticed it because I'm writing a driver for a similar device,
it was not even reported by anyone.

> Applied to the fixes-togreg branch of iio.git and marked for stable.
>
> Note that branch will probably be rebased after rc1 as I have some
> other things that need rc1 which will be in same pull request.
>
> Jonathan
>
> > ---
> >   drivers/iio/adc/ad7124.c | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/iio/adc/ad7124.c b/drivers/iio/adc/ad7124.c
> > index e45c600fccc0..18c154afbd7a 100644
> > --- a/drivers/iio/adc/ad7124.c
> > +++ b/drivers/iio/adc/ad7124.c
> > @@ -76,7 +76,7 @@
> >   #define AD7124_CONFIG_REF_SEL(x)	FIELD_PREP(AD7124_CONFIG_REF_SEL_MSK, x)
> >   #define AD7124_CONFIG_PGA_MSK		GENMASK(2, 0)
> >   #define AD7124_CONFIG_PGA(x)		FIELD_PREP(AD7124_CONFIG_PGA_MSK, x)
> > -#define AD7124_CONFIG_IN_BUFF_MSK	GENMASK(7, 6)
> > +#define AD7124_CONFIG_IN_BUFF_MSK	GENMASK(6, 5)
> >   #define AD7124_CONFIG_IN_BUFF(x)	FIELD_PREP(AD7124_CONFIG_IN_BUFF_MSK, x)
> >   
> >   /* AD7124_FILTER_X */