Re: [PATCH 3/4] staging: r8188eu: ODM_RF_CALIBRATION is always set
From: Martin Kaiser
Date: Wed Jan 26 2022 - 03:30:23 EST
Hi Dan,
Thus wrote Dan Carpenter (dan.carpenter@xxxxxxxxxx):
> On Sat, Jan 22, 2022 at 06:05:46PM +0100, Martin Kaiser wrote:
> > @@ -36,10 +35,6 @@ static void Init_ODM_ComInfo_88E(struct adapter *Adapter)
> > ODM_CmnInfoInit(dm_odm, ODM_CMNINFO_MP_TEST_CHIP, IS_NORMAL_CHIP(hal_data->VersionID));
> > ODM_CmnInfoInit(dm_odm, ODM_CMNINFO_RF_ANTENNA_TYPE, hal_data->TRxAntDivType);
> > -
> > - pdmpriv->InitODMFlag = ODM_RF_CALIBRATION;
> > -
> > - ODM_CmnInfoUpdate(dm_odm, ODM_CMNINFO_ABILITY, pdmpriv->InitODMFlag);
> Wait, why did you remove the ODM_CmnInfoUpdate()?
I removed the last item that Init_ODM_ComInfo_88E added to
pdmpriv->InitODMFlag. Init_ODM_ComInfo_88E does no longer modify
pdmpriv->InitODMFlag, there's no need for updating the odm internal
status.
Best regards,
Martin