RE: [RFC PATCH v3 15/32] x86/fred: make unions for the cs and ss fields in struct pt_regs
From: Li, Xin3
Date: Fri Feb 24 2023 - 11:34:52 EST
> > + union {
> > + unsigned long csl; /* CS + any fields above it */
>
> I guess that CSL here is supposed to mean cs long, but CSL (Current Stack Level) is a
> new term in the FRED spec which isn't this.
Good catch!
>
> This causes changes such as the final hunk in patch 27 to read incorrectly, despite
> being technically correct.
>
> cs_slot would be much clearer in code, but tbh, even cs_l would be better than the
> version without an underscore.
cs_slot sounds a good term unless someone comes up with a better one.
>
> And obviously, whatever is done here should be mirrored for ss.
Probably ss_slot then.
Xin