Re: [RFC][PATCH] cifs: Fix cifs_writepages_region()
From: David Howells
Date: Fri Feb 24 2023 - 12:20:28 EST
Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx> wrote:
> Can you humor me, and try if just removing that skip count thing
> instead? IOW, this attached patch?
That works too.
> Because that whole "let's stop writing if we need to reschedule" sounds
> truly odd (we have a cond_resched(), although it's per folio batch, not
> per-folio), and the skip count logic doesn't make much sense to me either.
The skip thing, in my code, is only used in WB_SYNC_NONE mode. If we hit 5
things in progress or rescheduling is required, we return to the caller on the
basis that conflicting flushes appear to be happening in other threads.
David