Re: [PATCH] workqueue: Introduce show_freeze_workqueues_busy
From: Tejun Heo
Date: Fri Mar 17 2023 - 18:16:29 EST
Hello,
A few nits.
On Wed, Mar 15, 2023 at 09:45:57PM +0900, Jungseung Lee wrote:
> diff --git a/kernel/power/process.c b/kernel/power/process.c
> index 6c1c7e5..590550f 100644
> --- a/kernel/power/process.c
> +++ b/kernel/power/process.c
> @@ -93,7 +93,7 @@ static int try_to_freeze_tasks(bool user_only)
> todo - wq_busy, wq_busy);
>
> if (wq_busy)
> - show_all_workqueues();
> + show_freeze_workqueues_busy();
Maybe name this show_freezable_workqueues()?
> @@ -5043,7 +5043,7 @@ static void show_one_worker_pool(struct worker_pool *pool)
> /**
> * show_all_workqueues - dump workqueue state
> *
> - * Called from a sysrq handler or try_to_freeze_tasks() and prints out
> + * Called from a sysrq handler and prints out
> * all busy workqueues and pools.
Can you reflow the comment to 80-col?
> +/**
> + * show_freeze_workqueues_busy - dump freezable workqueue state
> + *
> + * Called from try_to_freeze_tasks() and prints out
> + * all freezable workqueues still busy.
Ditto.
Thanks.
--
tejun