Re: [PATCH] ata: Disable NCQ_TRIM on Micron 1100 drives

[Niklas Cassel]

On Wed, Aug 30, 2023 at 05:02:22PM -0700, Pawel Zmarzly wrote:

Hello Pawel,

> Micron 1100 drives lock up when encountering queued TRIM command.
> It is a quite old hardware series, for past years we have been
> running our machines with these drives using
> libata.force=noncqtrim.
> 
> Signed-off-by: Pawel Zmarzly <pzmarzly@xxxxxxxx>
> ---
>  drivers/ata/libata-core.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
> index 175b2a9dc000..d2466f2c5fea 100644
> --- a/drivers/ata/libata-core.c
> +++ b/drivers/ata/libata-core.c
> @@ -4564,6 +4564,8 @@ static const struct ata_blacklist_entry ata_device_blacklist [] = {
>  						ATA_HORKAGE_ZERO_AFTER_TRIM, },
>  	{ "FCCT*M500*",			NULL,	ATA_HORKAGE_NO_NCQ_TRIM |
>  						ATA_HORKAGE_ZERO_AFTER_TRIM, },
> +	{ "Micron_1100_*",		NULL,	ATA_HORKAGE_NO_NCQ_TRIM |
> +					ATA_HORKAGE_ZERO_AFTER_TRIM, },

Please align ATA_HORKAGE_ZERO_AFTER_TRIM to ATA_HORKAGE_NO_NCQ_TRIM,
instead of aligning it to NULL. (That way it matches the existing entries.)


Kind regards,
Niklas