Re: [PATCH 2/2] arm64: dts: imx8mp: add reserve-memory nodes for DSP

[Iuliana Prodan]

On 9/12/2023 10:07 AM, Krzysztof Kozlowski wrote:
> On 12/09/2023 00:44, Iuliana Prodan (OSS) wrote:
> > From: Iuliana Prodan <iuliana.prodan@xxxxxxx>
> >
> > Add the reserve-memory nodes used by DSP when the rpmsg
> > feature is enabled.
> > These can be later used in a dsp node, like:
> > dsp: dsp@3b6e8000 {
> > 	compatible = "fsl,imx8mp-dsp";
> > 	reg = <0x3b6e8000 0x88000>;
> > 	mbox-names = "tx0", "rx0", "rxdb0";
> > 	mboxes = <&mu2 2 0>, <&mu2 2 1>,
> > 		<&mu2 3 0>, <&mu2 3 1>;
> > 	memory-region = <&dsp_vdev0buffer>, <&dsp_vdev0vring0>,
> > 		<&dsp_vdev0vring1>, <&dsp_reserved>;
> > 	status = "okay";
> Drop this example from commit msg, useless and not really correct.
Ok, will drop it. But this is a correct example, is just incomplete.
> > };
> >
> > Signed-off-by: Iuliana Prodan <iuliana.prodan@xxxxxxx>
> > ---
> >   arch/arm64/boot/dts/freescale/imx8mp.dtsi | 12 ++++++++++++
> >   1 file changed, 12 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/freescale/imx8mp.dtsi b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> > index cc406bb338fe..eedc1921af62 100644
> > --- a/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> > +++ b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> > @@ -210,6 +210,18 @@
> >   		dsp_reserved: dsp@92400000 {
> >   			reg = <0 0x92400000 0 0x2000000>;
> >   			no-map;
> Please test the patches before sending. This does not build.

I've tested on remoteproc tree, but it seems I missed a bracket when 
sending upstream. Sorry abut this, will fix it in v2.

Should I test this on other tree(s)?

Thanks,
Iulia

> Best regards,
> Krzysztof