Re: [PATCH V2] dt-bindings: nvmem: move deprecated cells binding to its own file

[Rafał Miłecki]

On 2023-10-24 16:24, Rob Herring wrote:
> On Tue, Oct 03, 2023 at 08:40:18AM +0200, Rafał Miłecki wrote:
> > From: Rafał Miłecki <rafal@xxxxxxxxxx>
> >
> > Support for old NVMEM fixed cells was deprecated in favour of
> > "fixed-layout". It's still part of the nvmem.yaml though and may be
> > unknowingly used by new bindings added without much of analyze.
> >
> > To make it more difficult to accidentally support old syntax move its
> > binding to separated file with "deprecated" in its name.
> >
> > Signed-off-by: Rafał Miłecki <rafal@xxxxxxxxxx>
> > ---
> > V2: Fix path to nvmem-deprecated-cells.yaml in amlogic,meson6-rtc.yaml
> >
> >  .../devicetree/bindings/mtd/mtd.yaml          |  7 ++++-
> >  .../bindings/mtd/partitions/nvmem-cells.yaml  |  1 +
> >  .../nvmem/amlogic,meson-gxbb-efuse.yaml       |  1 +
> >  .../bindings/nvmem/amlogic,meson6-efuse.yaml  |  1 +
> >  .../bindings/nvmem/apple,efuses.yaml          |  1 +
> >  .../devicetree/bindings/nvmem/imx-ocotp.yaml  |  1 +
> >  .../bindings/nvmem/mediatek,efuse.yaml        |  1 +
> >  .../nvmem/microchip,sama7g5-otpc.yaml         |  1 +
> >  .../devicetree/bindings/nvmem/mxs-ocotp.yaml  |  1 +
> >  .../nvmem/nvmem-deprecated-cells.yaml         | 28 
> > +++++++++++++++++++
> >  .../devicetree/bindings/nvmem/nvmem.yaml      |  9 ------
> >  .../bindings/nvmem/qcom,qfprom.yaml           |  1 +
> >  .../bindings/nvmem/qcom,sec-qfprom.yaml       |  1 +
> >  .../bindings/nvmem/qcom,spmi-sdam.yaml        |  1 +
> >  .../bindings/nvmem/rockchip,otp.yaml          |  1 +
> >  .../bindings/nvmem/rockchip-efuse.yaml        |  1 +
> >  .../nvmem/socionext,uniphier-efuse.yaml       |  1 +
> >  .../bindings/nvmem/sunplus,sp7021-ocotp.yaml  |  1 +
> >  .../bindings/rtc/amlogic,meson6-rtc.yaml      |  1 +
> >  19 files changed, 50 insertions(+), 10 deletions(-)
> >  create mode 100644 
> > Documentation/devicetree/bindings/nvmem/nvmem-deprecated-cells.yaml
>
> You missed allwinner,sun4i-a10-sid.yaml and at24.yaml
> (arch/arm/boot/dts/broadcom/bcm53016-meraki-mr32.dts). Maybe we want to
> fix the latter case because at24 will continually have new users.

I see. I looked at examples and DTS files with "allwinner,sun4i-a10-sid"
binding but I missed others. For reference fixed cells are used in:
1. sun50i-a64.dtsi
2. sun50i-h6.dtsi
3. sun50i-a100.dtsi

I'll fix that soon!

--
Rafał Miłecki