Re: [PATCH 2/2] x86/barrier: Do not serialize MSR accesses on AMD

From: Borislav Petkov
Date: Fri Oct 27 2023 - 15:16:58 EST


On Fri, Oct 27, 2023 at 08:56:41PM +0200, Peter Zijlstra wrote:
> Well, you see, AFAICT the non-serializing MSRs thing is an Intel thing,
> so everything !Intel wants this gone, no?
>
> Definitely the Hygon thing wants this right along with AMD, because
> that's basically AMD, no?

Because of

ce4e240c279a ("x86: add x2apic_wrmsr_fence() to x2apic flush tlb paths")

and it being there since 2009 and getting called unconditionally.

Hygon sure, but the other vendors? I can't even test on some.

Thus the more conservative approach here.

--
Regards/Gruss,
Boris.

https://people.kernel.org/tglx/notes-about-netiquette