Re: [PATCH 1/2] dt-bindings: interconnect: Add Qualcomm SC8380XP SoC

[Sibi Sankar]

Hey Krzysztof,


On 10/25/23 19:20, Krzysztof Kozlowski wrote:
> On 25/10/2023 15:40, Sibi Sankar wrote:
> > From: Rajendra Nayak <quic_rjendra@xxxxxxxxxxx>
> >
> > The Qualcomm SC8380XP SoC has several bus fabrics that could be controlled
> > and tuned dynamically according to the bandwidth demand.
>
>
> ...
>
> > +  reg:
> > +    maxItems: 1
> > +
> > +allOf:
> > +  - $ref: qcom,rpmh-common.yaml#
> > +  - if:
> > +      properties:
> > +        compatible:
> > +          contains:
> > +            enum:
> > +              - qcom,sc8380xp-clk-virt
> > +              - qcom,sc8380xp-mc-virt
> > +    then:
> > +      properties:
> > +        reg: false
> > +    else:
> > +      required:
> > +        - reg
> > +
> > +required:
> > +  - compatible
>
> By convention we put required: block before allOf: and that's what
> existing recent code has (qcom,sc8280xp-rpmh.yaml or
> qcom,sc7280-rpmh.yaml' for example). Please use recent files as a
> template for new bindings, so there will not be a need to fix the same
> things again.
>
> With fixes like in qcom,sc7280-rpmh.yaml:

Thanks will fix ^^

-Sibi

> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
>
> > +
> > +unevaluatedProperties: false
> Best regards,
> Krzysztof