Re: [PATCH v2] extcon: usbc-tusb320: Set interrupt polarity based on device-tree
From: Lukas Funke
Date: Mon Dec 04 2023 - 08:23:08 EST
Hi Chanwoo,
On 04.12.2023 13:49, Chanwoo Choi wrote:
-----Original Message-----
From: Chanwoo Choi <cw00.choi@xxxxxxxxxxx>
Sent: Monday, December 4, 2023 9:33 PM
To: 'Lukas Funke' <lukas.funke-oss@xxxxxxxxxxxxxxx>; 'lkp@xxxxxxxxx'
<lkp@xxxxxxxxx>; 'MyungJoo Ham' <myungjoo.ham@xxxxxxxxxxx>
Cc: 'Lukas.Funke@xxxxxxxxxxxxxxx' <Lukas.Funke@xxxxxxxxxxxxxxx>; 'linux-
kernel@xxxxxxxxxxxxxxx' <linux-kernel@xxxxxxxxxxxxxxx>; 'oe-kbuild-
all@xxxxxxxxxxxxxxx' <oe-kbuild-all@xxxxxxxxxxxxxxx>; 'Lukas Funke'
<lukas.funke@xxxxxxxxxxxxxxx>
Subject: RE: [PATCH v2] extcon: usbc-tusb320: Set interrupt polarity based
on device-tree
-----Original Message-----
From: Chanwoo Choi <cw00.choi@xxxxxxxxxxx>
Sent: Monday, December 4, 2023 9:09 PM
To: 'Lukas Funke' <lukas.funke-oss@xxxxxxxxxxxxxxx>; 'lkp@xxxxxxxxx'
<lkp@xxxxxxxxx>; 'MyungJoo Ham' <myungjoo.ham@xxxxxxxxxxx>
Cc: 'Lukas.Funke@xxxxxxxxxxxxxxx' <Lukas.Funke@xxxxxxxxxxxxxxx>;
'linux- kernel@xxxxxxxxxxxxxxx' <linux-kernel@xxxxxxxxxxxxxxx>;
'oe-kbuild- all@xxxxxxxxxxxxxxx' <oe-kbuild-all@xxxxxxxxxxxxxxx>; 'Lukas
Funke'
<lukas.funke@xxxxxxxxxxxxxxx>
Subject: RE: [PATCH v2] extcon: usbc-tusb320: Set interrupt polarity
based on device-tree
-----Original Message-----
From: Lukas Funke <lukas.funke-oss@xxxxxxxxxxxxxxx>
Sent: Wednesday, November 22, 2023 5:08 PM
To: lkp@xxxxxxxxx; MyungJoo Ham <myungjoo.ham@xxxxxxxxxxx>; Chanwoo
Choi <cw00.choi@xxxxxxxxxxx>
Cc: Lukas.Funke@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx;
lukas.funke- oss@xxxxxxxxxxxxxxx; oe-kbuild-all@xxxxxxxxxxxxxxx;
Lukas Funke <lukas.funke@xxxxxxxxxxxxxxx>
Subject: [PATCH v2] extcon: usbc-tusb320: Set interrupt polarity
based on device-tree
From: Lukas Funke <Lukas.Funke@xxxxxxxxxxxxxxx>
Remove 'IRQF_TRIGGER_FALLING' request which is not allowed on every
interrupt controller (i.e. arm64 GIC). Replace flag by a request
that depends on the actual device-tree setting.
Reported-by: kernel test robot <lkp@xxxxxxxxx>
Closes: https://lore.kernel.org/oe-kbuild-all/202311221355.yxYpTIw3-
lkp@xxxxxxxxx/
Signed-off-by: Lukas Funke <lukas.funke@xxxxxxxxxxxxxxx>
---
drivers/extcon/extcon-usbc-tusb320.c | 13 ++++++++++++-
1 file changed, 12 insertions(+), 1 deletion(-)
diff --git a/drivers/extcon/extcon-usbc-tusb320.c
b/drivers/extcon/extcon- usbc-tusb320.c index
4d08c2123e59..140ab28dbd36 100644
--- a/drivers/extcon/extcon-usbc-tusb320.c
+++ b/drivers/extcon/extcon-usbc-tusb320.c
@@ -17,6 +17,7 @@
#include <linux/usb/typec.h>
#include <linux/usb/typec_altmode.h> #include <linux/usb/role.h>
+#include <linux/irq.h>
#define TUSB320_REG8 0x8
#define TUSB320_REG8_CURRENT_MODE_ADVERTISE GENMASK(7, 6)
@@ -515,6 +516,8 @@ static int tusb320_probe(struct i2c_client
*client)
const void *match_data;
unsigned int revision;
int ret;
+ int irq_pol;
+ struct irq_data *irq_d;
priv = devm_kzalloc(&client->dev, sizeof(*priv), GFP_KERNEL);
if (!priv)
@@ -568,9 +571,17 @@ static int tusb320_probe(struct i2c_client
*client)
*/
tusb320_state_update_handler(priv, true);
+ irq_d = irq_get_irq_data(client->irq);
+ if (!irq_d) {
+ dev_err(&client->dev, "Invalid IRQ: %d\n", client->irq);
+ return -ENODEV;
+ }
+
+ irq_pol = irqd_get_trigger_type(irq_d);
+
ret = devm_request_threaded_irq(priv->dev, client->irq, NULL,
tusb320_irq_handler,
- IRQF_TRIGGER_FALLING | IRQF_ONESHOT,
+ IRQF_ONESHOT | irq_pol,
client->name, priv);
if (ret)
tusb320_typec_remove(priv);
--
2.30.2
Applied it. Thanks.
Best Regards,
Chanwoo Choi
In order to remove the build warning, I changed the variable type
of 'irq_pol' as following:
index 140ab28dbd36..cec1889549a6 100644
--- a/drivers/extcon/extcon-usbc-tusb320.c
+++ b/drivers/extcon/extcon-usbc-tusb320.c
@@ -516,7 +516,7 @@ static int tusb320_probe(struct i2c_client *client)
const void *match_data;
unsigned int revision;
int ret;
- int irq_pol;
+ u32 irq_pol;
struct irq_data *irq_d;
priv = devm_kzalloc(&client->dev, sizeof(*priv), GFP_KERNEL);
Best Regards,
Chanwoo Choi
How about changing this patch as following?
When irq_getg_irq_data returns NULL, just use the IRQF_TRIGGER_FALLING flag
to support previous version. Because I didn't' check the all use-case
of this driver on DT. I think that better to keep the IRQF_TRIGGER_FALLING
flag
when irq_d is NULL.
Good call. Just one minor change to make the 'else' obsolete (see below).
Best regards
Lukas Funke
diff --git a/drivers/extcon/extcon-usbc-tusb320.c
b/drivers/extcon/extcon-usbc-tusb320.c
index 4d08c2123e59..bd5ed8dd8fdd 100644
--- a/drivers/extcon/extcon-usbc-tusb320.c
+++ b/drivers/extcon/extcon-usbc-tusb320.c
@@ -17,6 +17,7 @@
#include <linux/usb/typec.h>
#include <linux/usb/typec_altmode.h>
#include <linux/usb/role.h>
+#include <linux/irq.h>
#define TUSB320_REG8 0x8
#define TUSB320_REG8_CURRENT_MODE_ADVERTISE GENMASK(7, 6)
@@ -515,6 +516,8 @@ static int tusb320_probe(struct i2c_client *client)
const void *match_data;
unsigned int revision;
int ret;
+ u32 irq_trigger_type = IRQF_TRIGGER_FALLING;
+ struct irq_data *irq_d;
priv = devm_kzalloc(&client->dev, sizeof(*priv), GFP_KERNEL);
if (!priv)
@@ -568,9 +571,15 @@ static int tusb320_probe(struct i2c_client *client)
*/
tusb320_state_update_handler(priv, true);
+ irq_d = irq_get_irq_data(client->irq);
+ if (irq_d)
+ irq_trigger_type = irqd_get_trigger_type(irq_d);
+
ret = devm_request_threaded_irq(priv->dev, client->irq, NULL,
tusb320_irq_handler,
- IRQF_TRIGGER_FALLING | IRQF_ONESHOT,
+ IRQF_ONESHOT | irq_trigger_type,
client->name, priv);
if (ret)
tusb320_typec_remove(priv);